Conversation
Just to be sure about it next time someone works on it
As the indexes have changed in the TomeRepo, might need some changes again latter as there are new bonuses
fixed decay calculation, bugged when a value was too high (thinking it was a string and concatenating it with the this.data.keyQty) Added the calculation for boundedDecay Changed how values are displayed Added new lines, with placeholder for values which can be done for now
Used to add everything Gambit related without cluttering too much the main file
In case we need it at some point for UI (might be missing some information tho)
Includes Jar bonuses and Jar types
In-game says challenge
Now include Gambit and Jar
Update to the Hole
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ESLint made me remember I forgot to complete this function (won't be used until we do some UI tho)
Sludging
left a comment
There was a problem hiding this comment.
Few minor things, overall looking good.
Tracking lines that didn't match up for me (regardless if you mentioned it or not, just keepign track for myself on what we have to update based on my own lines):
- Star Talent Points Owned
- Total Best Wave in Worship
- Total Digits of all Deathnote Kills
- Total Onyx Statues (is this actually counting zenith?)
- Total Artifacts Found
- Total Career Summoning Wins
- Total Summoning Boss Stone victories
- Total Coral Reef upgrades
- Total Spelunk Shop Upgrades LV
- Total Spelunk Discoveries made
- Deepest Depth reached in a single Delve
- Biggest Haul in a single Delve
Other notes:
- Most Gaming Bits Owned - needs better formatting lol, we should have a bit formatter option for nformatter I think, if not I stole some implementation from Toolbox that might have it
Co-authored-by: Sludging <30924533+Sludging@users.noreply.github.com>
Co-authored-by: Sludging <30924533+Sludging@users.noreply.github.com>
Co-authored-by: Sludging <30924533+Sludging@users.noreply.github.com>
Now have a preciseTime boolean parameter Let you hide hours and minutes if there's none, and let you get the first decimal of the seconds if there's some
Now use a static fromBase for consistency
|
To add to what's in the other comments, Onyx statues count is off because Zenith statues are counted in-game, but in IE it checks for statue.type == StatusType.Onyx |
Sludging
left a comment
There was a problem hiding this comment.
Good work on this, let's go!
Easy follow up from this to fix up some of the lines that are off now and we can add it to the change log once we fix everything and the tome score is accurate again.
Merging this in.
Updated the Tome to include all new lines
I also fixed some old ones which broken
Some of the new lines won't be able to calculate the score as the values aren't there yet (spelunking mostly), there's a TODO for all those.
I also worked on the Hole to get some missing informations I needed (and I guess will be useful anyway for other parts of the site)